Update http_client.rb to fix detect_provider problem #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect Provider calls build_query method from Auth.rb instead of http_client.rb. By renaming the private method build_query to build_http_query on http_client.rb the problem is solved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 24 24
Lines 665 665
=======================================
Hits 664 664
Misses 1 1 ☔ View full report in Codecov by Sentry. |
mrashed-dev
approved these changes
Mar 1, 2024
mrashed-dev
deleted the
Ruby-SDK---Detect-Provider-call-wrong-build_query-method
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detect Provider calls build_query method from Auth.rb instead of http_client.rb. By renaming the private method build_query to build_http_query on http_client.rb the problem is solved.
https://nylas.atlassian.net/browse/TW-2704
https://nylas.atlassian.net/browse/TW-2705
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.