Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default timeout to match API (90 seconds) #471

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Change default timeout to match API (90 seconds) #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cff3f9
Change default timeout to match API (90 seconds)
mrashed-dev Mar 1, 2024
2165857
Merge branch 'main' into TW-2712-sdk-v-3-update-default-timeout-to-90…
mrashed-dev Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

### Unreleased
* Change default timeout to match API (90 seconds)

### 6.0.2 / 2024-02-27
* Fixed the HTTP operation of updating grants
* Fixed endpoint URL of rotating webhooks
Expand Down
2 changes: 1 addition & 1 deletion lib/nylas/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def initialize(api_key:,
timeout: nil)
@api_key = api_key
@api_uri = api_uri
@timeout = timeout || 30
@timeout = timeout || 90
end

# The application resources for your Nylas application.
Expand Down
4 changes: 2 additions & 2 deletions spec/nylas/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

expect(nylas.api_key).to eq("fake-key")
expect(nylas.api_uri).to eq("https://api.us.nylas.com")
expect(nylas.timeout).to eq(30)
expect(nylas.timeout).to eq(90)
end
end

Expand All @@ -18,7 +18,7 @@

expect(nylas.api_key).to eq("fake-key")
expect(nylas.api_uri).to eq("https://custom.nylas.com")
expect(nylas.timeout).to eq(30)
expect(nylas.timeout).to eq(90)
end
end

Expand Down
Loading