Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency on ostruct gem #491

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add dependency on ostruct gem #491

merged 2 commits into from
Sep 24, 2024

Conversation

mrashed-dev
Copy link
Collaborator

Description

As reported by @bmulholland:

warning: lib/ruby/3.3.0/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of nylas-6.1.1 to request adding ostruct into its gemspec.

Closes #489.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

atejada
atejada approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@atejada atejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mrashed-dev mrashed-dev merged commit 7cac99c into main Sep 24, 2024
5 checks passed
@mrashed-dev mrashed-dev deleted the TW-3441-ruby-gh-489-add-explicit-dependency-on-ostruct branch September 24, 2024 16:44
@mrashed-dev mrashed-dev mentioned this pull request Sep 24, 2024
Merged
mrashed-dev added a commit that referenced this pull request Sep 24, 2024
@mrashed-dev
v6.2.0 Release (#493)
d2f07ed 
# Changelog

## Added
* Added query support for folders (#492, #488)
* Added dependency on `ostruct` gem (#491, #489)
* Enable SDK to reattach large files to messages on retry (#487)

## Changed
* Downgraded `rest-client` to `2.0` for better compatibility (#490)
@bmulholland
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atejada atejada atejada approved these changes

@AaronDDM AaronDDM Awaiting requested review from AaronDDM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explicit dependency on ostruct
3 participants
@mrashed-dev @bmulholland @atejada