Feature Noise XKpsk3 IP from bond #4451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
approved these changes
Mar 11, 2024
| impl<'a> From<&'a Node> for SphinxNode { | ||
| fn from(node: &'a Node) -> Self { | ||
| let node_address_bytes = NymNodeRoutingAddress::from(node.mix_host) | ||
| let node_address_bytes = NymNodeRoutingAddress::from(node.mix_hosts[0]) |
| impl<'a> From<&'a Node> for SphinxNode { | ||
| fn from(node: &'a Node) -> Self { | ||
| let node_address_bytes = NymNodeRoutingAddress::from(node.mix_host) | ||
| let node_address_bytes = NymNodeRoutingAddress::from(node.mix_hosts[0]) |
jstuczyn
reviewed
Mar 11, 2024
| #[cfg_attr(feature = "wasm-serde-types", tsify(optional))] | ||
| #[serde(alias = "explicit_ip")] | ||
| pub explicit_ip: Option<IpAddr>, | ||
| pub explicit_ips: Option<Vec<IpAddr>>, |
Contributor
There was a problem hiding this comment.
this might break --custom-mixnet flag. please double check.
Contributor
Author
There was a problem hiding this comment.
In the current state, --custom-mixnet is broken anyway because it doesn't exist on mix nodes and gateway. This doesn't mean that it will stay broken though
| owner: value.owner.clone(), | ||
| host: value.host.to_string(), | ||
| mix_port: Some(value.mix_host.port()), | ||
| mix_port: Some(value.mix_hosts[0].port()), |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR on top of #4360.
This PR remove the need of accurate information in the
self-describedAPI (apart from the noise support)IPs are retrieved from the bond, if it is a hostname, it will use the same resolving mechanism that currently exists. All resolved IPs are kept instead of just one.
Checklist:
CHANGELOG.md