Skip to content

Conversation

@jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jul 11, 2024

gateway and mixnode commands now won't do anything without explicit --force-run to bypass the deprecation.

the next step, in say a month or so, is to completely remove all cli related things.

@jstuczyn jstuczyn requested a review from octol as a code owner July 11, 2024 14:53
@jstuczyn jstuczyn added this to the TopDeck milestone Jul 11, 2024
@jstuczyn jstuczyn changed the title removed mixnode/gateway config migration code and disabled commands without explicit flag removed mixnode/gateway config migration code and disabled cli without explicit flag Jul 11, 2024
@vercel
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 3:20pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 3:20pm

@jstuczyn jstuczyn force-pushed the chore/remove-old-migration-code branch from c5aacca to c253b22 Compare July 11, 2024 15:20
@jstuczyn jstuczyn merged commit 6478736 into develop Jul 23, 2024
@jstuczyn jstuczyn deleted the chore/remove-old-migration-code branch July 23, 2024 14:11
@benedettadavico
Copy link
Contributor

Testing Completion Date: 30/07/2024

Testing Steps Performed:

  • Verified that the nym-gateway binary and nym-mixnode binary commands return the error message stating to update to nym-node
  • checked that when adding the --force-run flag, it still allows the command to be run (aside from init which has been removed) and the message stating to update to nym-node is a warning now
  • Checked nym-node is not affected
  • Reviewed the changes in the PR

Validation:

  • [x ] Test Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants