Skip to content

Feature/vesting purge plus ranged cost params #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jstuczyn merged 27 commits into from
Jul 26, 2024
Merged

Feature/vesting purge plus ranged cost params #4716

jstuczyn merged 27 commits into from
Jul 26, 2024

Conversation

@jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jul 18, 2024

Combines #4715 and #4711 into one.

What it does:

  • disables all non-essential operations on the vesting contract => you can no longer bond mixnodes/make delegations/etc. (you can still, however, withdraw your vested tokens and so on)
  • introduces admin-controlled minimum (and maximum) profit margin and interval operating costs.

Changes:

  • during [mixnet contract] instantiation you can optionally provide those ranges

Migrations:

  • both contracts have to be migrated at the same time. ideally within the same transaction
  • mixnet contract migration is not allowed (and will fail) if there are any pending actions involving vesting tokens, like delegating, increasing pledge, etc

This was referenced Jul 18, 2024
Closed
Closed
@jstuczyn jstuczyn added this to the TopDeck milestone Jul 18, 2024
@vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 4:29pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 4:29pm

@jstuczyn jstuczyn modified the milestones: TopDeck, Caramello Jul 23, 2024
@fmtabbara fmtabbara force-pushed the feature/vesting-purge-plus-ranged-cost-params branch from 07f8917 to 2b33835 Compare July 25, 2024 17:25
@jstuczyn jstuczyn marked this pull request as ready for review July 26, 2024 10:15
@jstuczyn jstuczyn requested review from durch and octol as code owners July 26, 2024 10:15
jstuczyn and others added 20 commits July 26, 2024 15:05
@jstuczyn @fmtabbara
removed all on_behalf mixnet contract methods
9767f72
@jstuczyn @fmtabbara
ensure no pending proxy events when migrating
701012a
@jstuczyn @fmtabbara
implemented migration into non-vesting mixnodes/delegations
c4f7a1e
@jstuczyn @fmtabbara
exposed migration commands to nym-cli + clippy
9179f1c
@jstuczyn @fmtabbara
updated contract schema
f57fe79
@jstuczyn @fmtabbara
fixed wallet vesting-related tests
952ed9b
@jstuczyn @fmtabbara
fixed vesting contract tests
70db1ad
@jstuczyn @fmtabbara
introduced the concept of allowed profit margin ranges
03ffb25
@jstuczyn @fmtabbara
normalise node's profit margin during rewarding
8704c21
@jstuczyn @fmtabbara
profit margin range validation
c2ab47a
@jstuczyn @fmtabbara
introducing allowed range of operator interval operating cost
9d0fd68
@jstuczyn @fmtabbara
added associated [hacky] wallet types
82f161f
@jstuczyn @fmtabbara
update contract schema
66979df
@jstuczyn @fmtabbara
fix nym-cli
b484f47
@jstuczyn @fmtabbara
missing test fixture
7b80203
@jstuczyn @fmtabbara
fixed post-rebasing imports
61ddeea
@jstuczyn @fmtabbara
cargo fmt
4ee445c
@mmsinclair @fmtabbara
Fix dependency issue
7d35102
@jstuczyn @fmtabbara
exposed tauri operations for vesting migrations
b76802e
@mmsinclair @fmtabbara
Dialog and mock for migrating vesting contract delegations
61fcd4a
@fmtabbara fmtabbara force-pushed the feature/vesting-purge-plus-ranged-cost-params branch from 6a83ef1 to ecee6ca Compare July 26, 2024 14:08
@fmtabbara fmtabbara force-pushed the feature/vesting-purge-plus-ranged-cost-params branch from bc8da97 to d1de751 Compare July 26, 2024 16:28
@jstuczyn jstuczyn merged commit dfb2a2f into develop Jul 26, 2024
@jstuczyn jstuczyn deleted the feature/vesting-purge-plus-ranged-cost-params branch July 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmsinclair mmsinclair mmsinclair approved these changes

@octol octol Awaiting requested review from octol

@durch durch Awaiting requested review from durch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Caramello

Development

Successfully merging this pull request may close these issues.

4 participants

@jstuczyn @mmsinclair @fmtabbara