Skip to content

Conversation

@octol
Copy link
Contributor

@octol octol commented Jul 25, 2024

Bump tokio to 1.39.2, skipping the issue with 1.39.1

@vercel
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 5:09pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 5:09pm

@octol octol requested a review from jstuczyn July 25, 2024 17:04
@octol octol force-pushed the jon/tokio-1.39-fixes branch from 42a852a to cefe66c Compare July 26, 2024 11:31
@octol octol requested a review from dynco-nym July 26, 2024 11:33
@octol octol added this to the Caramello milestone Jul 26, 2024
Copy link
Contributor

@dynco-nym dynco-nym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

octol added 4 commits July 29, 2024 18:56
Fix the error generated by tokio 1.39

72 | /             tokio::select! {
173 | |                 daemon_res = &mut fused_runner => {
174 | |                     warn!("the daemon has terminated by itself - was it a short lived command?");
175 | |                     let exit_status = daemon_res?;
...   |
179 | |                 event = &mut self.upgrade_plan_watcher.next() => {
    | |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
...   |
201 | |                 }
202 | |             }
    | |             -
    | |             |
    | |_____________temporary value is freed at the end of this statement
    |               borrow later used here

and

62 | /         select! {
63 | |             connection_message = &mut mix_receiver.next() => {
   | |                                       ^^^^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
64 | |                 if let Some(connection_message) = connection_message {
65 | |                     if deal_with_message(connection_message, &mut writer, &local_destination_address, &remote_source_address, connection_id).await {
...  |
86 | |             }
87 | |         }
   | |         -
   | |         |
   | |_________temporary value is freed at the end of this statement
   |           borrow later used here
@octol octol force-pushed the jon/tokio-1.39-fixes branch from cefe66c to 313b443 Compare July 29, 2024 17:03
@octol octol merged commit 32e2557 into develop Jul 29, 2024
@octol octol deleted the jon/tokio-1.39-fixes branch July 29, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants