-
Notifications
You must be signed in to change notification settings - Fork 264
Fix tokio error in 1.39 #4730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix tokio error in 1.39 #4730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
42a852a to
cefe66c
Compare
dynco-nym
reviewed
Jul 26, 2024
dynco-nym
approved these changes
Jul 26, 2024
Contributor
dynco-nym
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Fix the error generated by tokio 1.39
72 | / tokio::select! {
173 | | daemon_res = &mut fused_runner => {
174 | | warn!("the daemon has terminated by itself - was it a short lived command?");
175 | | let exit_status = daemon_res?;
... |
179 | | event = &mut self.upgrade_plan_watcher.next() => {
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
... |
201 | | }
202 | | }
| | -
| | |
| |_____________temporary value is freed at the end of this statement
| borrow later used here
and
62 | / select! {
63 | | connection_message = &mut mix_receiver.next() => {
| | ^^^^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
64 | | if let Some(connection_message) = connection_message {
65 | | if deal_with_message(connection_message, &mut writer, &local_destination_address, &remote_source_address, connection_id).await {
... |
86 | | }
87 | | }
| | -
| | |
| |_________temporary value is freed at the end of this statement
| borrow later used here
cefe66c to
313b443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump tokio to 1.39.2, skipping the issue with 1.39.1