Skip to content

Better storage error logging #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neacsu merged 2 commits into from
Aug 20, 2024
Merged

Better storage error logging #4772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c3c21a
Better storage error logging
neacsu Aug 20, 2024
25d88e9
Print without including error returned to clients
neacsu Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions gateway/src/node/client_handling/websocket/connection_handler/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-License-Identifier: GPL-3.0-only

use crate::config::Config;
use fresh::InitialAuthenticationError;
use nym_credentials_interface::AvailableBandwidth;
use nym_gateway_requests::registration::handshake::SharedKeys;
use nym_gateway_requests::ServerResponse;
Expand Down Expand Up @@ -122,6 +123,12 @@ pub(crate) async fn handle_connection<R, S, St>(
trace!("received shutdown signal while performing initial authentication");
return;
}
// For storage error, we want to print the extended storage error, but without
// including it in the error that's returned to the clients
Some(Err(InitialAuthenticationError::StorageError(err))) => {
warn!("authentication has failed: {err}");
return;
}
Some(Err(err)) => {
warn!("authentication has failed: {err}");
return;
Expand Down