-
Notifications
You must be signed in to change notification settings - Fork 265
feat: initial performance contract #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
8c24e97 to
6ce589e
Compare
durch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few random thoughts:
FullHistoricalPerformancePagedcould become quite expensive- Performance input validation (0-100)
- Check that NodeIDs exist in the contract
- Maybe adding batch size limits for DoS protection
- Some sort of a data retention strategy, should we ever want to drop old performance data
yep. though I wouldn't expect it to be called by anyone too often. it's just exposed for convenience. quite similarly to the query to retrieve all mixnet delegations.
that's done during deserialisation. performance is wrapped in a
I like this one! though I wonder what should we do in a situation where network monitor is catching up and the node has unbonded. i.e. we are in say epoch 10. node has unbonded in epoch 9 and network monitor is submitting for epoch 8. I guess maybe that data should just get ignored.
Another good point. Though I wonder how necessary it might be, because if transaction is too big, the chain will fail to execute it (and you will lose your gas fees)
yeah, I've been thinking about that one... currently I've gone with the simplest solution of retain everything, but I don't know... |
3ba03a1 to
0fb2d8f
Compare
this PR introduces basic structure of the performance contract. it is not yet integrated into any system as this will be part of future PRs. you can read more about the inner workings of the contract on the confluence page.
This change is