Skip to content

Conversation

@jmwample
Copy link
Contributor

@jmwample jmwample commented Jun 16, 2025

Allow SURBs to be sent configured to only use gateways in mixnet return path.

Follow on to #5696

Tested as working with mainnet vpnd/vpnc client for a handful of manual connections.


This change is Reviewable

@vercel
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nym-explorer-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 8:37pm
nym-next-explorer ❌ Failed (Inspect) Jun 20, 2025 8:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 8:37pm

@jmwample
Copy link
Contributor Author

@jstuczyn I don't know how broadly the use_legacy_sphinx_format settings apply. Given that we have looked at the coverage that the update has in node currently Is it okay to update the default to where clients will use the updated sphinx format? Or should we leave the legacy format as default and make this this be more targeted somehow?

@jstuczyn
Copy link
Contributor

@jstuczyn I don't know how broadly the use_legacy_sphinx_format settings apply. Given that we have looked at the coverage that the update has in node currently Is it okay to update the default to where clients will use the updated sphinx format? Or should we leave the legacy format as default and make this this be more targeted somehow?

so the thing is, it will apply to every packet constructed by the client. meaning we'd expect every mixnod, gateway and service provider on the route to be compatible with that change (otherwise they'd be dropping the packets or failing to parse them). ideally, maybe for now, we should do it in a more targetted way to just affect the vpn registration?

@jmwample
Copy link
Contributor Author

jmwample commented Jun 20, 2025

we should do it in a more targetted way to just affect the vpn registration

How about this solution: If the client configures disabled_mix_hops it overrides the use_legacy_sphinx_format setting by necessity, creating its own exception. For now this only happens in the registration mixnet client. This way you have to intentionally enable a feature (that is disabled by default) to use this format.

When we are ready we can look into changing the default setting independently.

@jmwample jmwample merged commit a7b57d7 into develop Jul 3, 2025
17 of 20 checks passed
@jmwample jmwample deleted the jmwample/optional-surb-mixhops branch July 3, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants