Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nym-node-status-api/nym-node-status-api/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

[package]
name = "nym-node-status-api"
version = "3.1.0"
version = "3.1.1"
authors.workspace = true
repository.workspace = true
homepage.workspace = true
Expand Down
4 changes: 4 additions & 0 deletions nym-node-status-api/nym-node-status-api/src/cli/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ pub(crate) struct Cli {
#[clap(long, env = "DATABASE_URL")]
pub(crate) database_url: String,

#[clap(long, default_value = "5", env = "SQLX_BUSY_TIMEOUT_S")]
#[arg(value_parser = parse_duration)]
pub(crate) sqlx_busy_timeout_s: Duration,

#[clap(
long,
default_value = "300",
Expand Down
32 changes: 30 additions & 2 deletions nym-node-status-api/nym-node-status-api/src/db/mod.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
use anyhow::{anyhow, Result};
use sqlx::{
migrate::Migrator,
query,
sqlite::{SqliteAutoVacuum, SqliteConnectOptions, SqliteSynchronous},
ConnectOptions, SqlitePool,
};
use std::str::FromStr;
use std::{str::FromStr, time::Duration};

pub(crate) mod models;
pub(crate) mod queries;
Expand All @@ -18,9 +19,10 @@ pub(crate) struct Storage {
}

impl Storage {
pub async fn init(connection_url: String) -> Result<Self> {
pub async fn init(connection_url: String, busy_timeout: Duration) -> Result<Self> {
let connect_options = SqliteConnectOptions::from_str(&connection_url)?
.journal_mode(sqlx::sqlite::SqliteJournalMode::Wal)
.busy_timeout(busy_timeout)
.synchronous(SqliteSynchronous::Normal)
.auto_vacuum(SqliteAutoVacuum::Incremental)
.foreign_keys(true)
Expand All @@ -33,11 +35,37 @@ impl Storage {

MIGRATOR.run(&pool).await?;

// aftering setting pragma, check whether it was set successfully
Self::assert_busy_timeout(pool.clone(), busy_timeout.as_secs() as i64).await?;

Ok(Storage { pool })
}

/// Cloning pool is cheap, it's the same underlying set of connections
pub fn pool_owned(&self) -> DbPool {
self.pool.clone()
}

async fn assert_busy_timeout(pool: DbPool, expected_busy_timeout_s: i64) -> Result<()> {
let mut conn = pool.acquire().await?;
// Sqlite stores this value as miliseconds
// https://www.sqlite.org/pragma.html#pragma_busy_timeout
let busy_timeout_db = query!("PRAGMA busy_timeout;")
.fetch_one(conn.as_mut())
.await?;

let actual_busy_timeout_ms = busy_timeout_db.timeout.unwrap_or(0);
tracing::info!("PRAGMA busy_timeout={}ms", actual_busy_timeout_ms);
let expected_busy_timeout_ms = expected_busy_timeout_s * 1000;

if expected_busy_timeout_ms != actual_busy_timeout_ms {
anyhow::bail!(
"PRAGMA busy_timeout expected: {}ms, actual: {}ms",
expected_busy_timeout_ms,
actual_busy_timeout_ms
);
}

Ok(())
}
}
2 changes: 1 addition & 1 deletion nym-node-status-api/nym-node-status-api/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ async fn main() -> anyhow::Result<()> {
let connection_url = args.database_url.clone();
tracing::debug!("Using config:\n{:#?}", args);

let storage = db::Storage::init(connection_url).await?;
let storage = db::Storage::init(connection_url, args.sqlx_busy_timeout_s).await?;
let db_pool = storage.pool_owned();

// Start the node scraper
Expand Down
Loading