Skip to content

Conversation

@georgio
Copy link
Contributor

@georgio georgio commented Jul 29, 2025

List of resolved Issues:

  • Zeroization
  • Unsafe code (lazy_static)
  • Heap allocations for constant sized values

This change is Reviewable

@georgio georgio requested a review from jstuczyn as a code owner July 29, 2025 14:27
@georgio georgio added the dkg label Jul 29, 2025
@georgio
Copy link
Contributor Author

georgio commented Jul 29, 2025

Issue "Heap allocations for constant sized values" is fixed here:

let mut bytes = [0u8; 96];
bytes[0..48].copy_from_slice(public_bytes.as_ref());
bytes[48..96].copy_from_slice(rand_commit_bytes.as_ref());

@vercel
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nym-explorer-v2 Ready Ready Preview Comment Sep 12, 2025 6:43pm
nym-node-status Ready Ready Preview Comment Sep 12, 2025 6:43pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs-nextra Ignored Ignored Preview Sep 12, 2025 6:43pm

Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove those needless zeroize calls and I think we can get this guy merged and over with

@georgio
Copy link
Contributor Author

georgio commented Oct 7, 2025

remove those needless zeroize calls and I think we can get this guy merged and over with

@jstuczyn zeroizations cost a few nanoseconds for keys and dl proof (4-7 on my machine). Zeroizing a chunking proof costs 1000x more which is still ~6 microseconds. I think we should keep those just in case there's a need for deniability or whatnot. I know it's an almost unrealistic edge-case, but the cost is negligible.

@georgio georgio merged commit b3a9407 into develop Oct 10, 2025
22 checks passed
@georgio georgio deleted the georgio/dkg-fixes branch October 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants