-
Notifications
You must be signed in to change notification settings - Fork 262
Additional DKG Fixes #5919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional DKG Fixes #5919
Conversation
|
Issue "Heap allocations for constant sized values" is fixed here: nym/common/dkg/src/bte/proof_discrete_log.rs Lines 55 to 57 in 6940ca4
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jstuczyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove those needless zeroize calls and I think we can get this guy merged and over with
@jstuczyn zeroizations cost a few nanoseconds for keys and dl proof (4-7 on my machine). Zeroizing a chunking proof costs 1000x more which is still ~6 microseconds. I think we should keep those just in case there's a need for deniability or whatnot. I know it's an almost unrealistic edge-case, but the cost is negligible. |
List of resolved Issues:
lazy_static)This change is