bugfix: Recipient deserialisation for deserialisers missing bytes specialisation #5991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cialisation for example toml or json will just default to visit_seq ignoring bytes related optimisations
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
pronebird
requested changes
Sep 1, 2025
Contributor
pronebird
left a comment
pronebird
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
common/nymsphinx/addressing/src/clients.rs line 111 at r2 (raw file):
#[allow(clippy::needless_range_loop)] for i in 0..Recipient::LEN { let Some(elem) = seq.next_element::<u8>()? else {
Can you not collect up to Recipient::LEN into Vec?
pronebird
approved these changes
Sep 1, 2025
Contributor
pronebird
left a comment
pronebird
left a comment
There was a problem hiding this comment.
@pronebird reviewed 1 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jstuczyn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example toml or json will just default to visit_seq ignoring bytes related optimisations
This change is