Max/crates io prep v2 #6270
Max/crates io prep v2 #6270
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Cargo.toml
Outdated
| license = "Apache-2.0" | ||
| rust-version = "1.85" | ||
| readme = "README.md" | ||
| version = "1.20.0" # this version is used for the Rust SDK and its workspace dependencies, it is not applied globally |
There was a problem hiding this comment.
by "its workspace dependencies", do you been exlusively things that are used by rust SDK or all common crates (I think it'd be good to keep it consistent for everything, especially if we were to add an extra dep to rust sdk)
There was a problem hiding this comment.
Its the crates that are used by the SDK only currently - I've added a note in the publishing.md file in the SDK re: adding workspace deps to the SDK
There was a problem hiding this comment.
my previous comment has become moot with my previous commits making basically everything aside from the binaries/contracts/tools follow the versioning structure, sidesteps this potential issue.
Cargo.toml
Outdated
|
|
||
| # sdk related deps so we can pull in workspace versions of these in other crates' cargo files, and not have to define the version everywhere | ||
| # nym-api = { version = "1.2.0", path = "nym-api" } | ||
| nym-bandwidth-controller = { version = "1.2.0", path = "common/bandwidth-controller" } |
There was a problem hiding this comment.
I'm not sure you have to specify the version on top here (plz double check), but if not, i'd remove it so we wouldn't cause some inconsistencies if we forget to update those
There was a problem hiding this comment.
This was the hacky way I found which allows us to define the workspace.version for the constituent crates. Maybe I can get rid of those.. Will experiment.
| [package] | ||
| name = "sqlx-pool-guard" | ||
| version = "0.1.0" | ||
| name = "nym-sqlx-pool-guard" |
There was a problem hiding this comment.
since you've renamed this, after the PR gets merged, create a draft on the vpn repo to update their dependencies (as they were importing it too)
publish-sdk.sh
Outdated
| --prev-tag-name "" \ | ||
| --no-push \ | ||
| --no-tag \ | ||
| --no-publish \ |
There was a problem hiding this comment.
well, if we actually want to publish it, we probably want to remove this flag : )
There was a problem hiding this comment.
Yeah will remove once we're happy with the dryrun and setup - was being doubly cautious so I didn't accidentally publish them when testing
- prepend sqlx-pool-guard with 'nym-'
publishing exclusion
mfahampshire
force-pushed
the
max/crates-io-prep-v2
branch
from
d07d3ad to
712ad35
Compare
This PR is prep work for publishing the Rust SDK + its workspace dependencies to crates.io.
Overall, this PR:
nym-sdkcrate; we want to keep them all in line with each otheradds a script to usecargo releaseto publish the SDK + its dependencies -cargo releasedeals with creating them in the correct ordercargo.tomlfileTodo:
publishing.mdwriteupThis change is