DNS static table pre-resolve #6297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonwicky
approved these changes
Dec 17, 2025
jmwample
added a commit
that referenced
this pull request
Jan 7, 2026
jmwample
added a commit
that referenced
this pull request
Jan 7, 2026
jstuczyn
pushed a commit
that referenced
this pull request
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In situations where the secure nameservers used to resolve internal domains fail we have the static fallback table to seed and ensure conncetivity. However, it requires that lookups using the default resolver fail first before the static table can be used. So if the nameservers are blocked or severly slowed then every use of the API will take a very long time, significantly slowing everything down.
ref #6178 - initial implemenation of the static fallback table
Solution
Add pre-resolve stage that returns addrs if we have used static table previously. This ensures that we don't continually suffer the penalty of a lookup timeout, while also allowing for the possibility of going back to the default internal secure resolver if one or more nameservers becomes usable again at a future time.
This change is