Merge pull request #11 from nypublicradio/mwalsh/safari-checkbox-erro…

…r-message-test-case

GT-1311 safari checkbox error message test case

app/components/personal-info/component.js

@@ -4,6 +4,7 @@ import { filter, not, and } from '@ember/object/computed';
 import makeSubmissionValidations from '../../validations/submission';
 import lookupValidator from 'ember-changeset-validations';
 import { get } from '@ember/object';
+import { next } from '@ember/runloop';
 
 export default Component.extend({
   tagName:    'form',
@@ -53,12 +54,20 @@ export default Component.extend({
       });
     },
     validateAgreement() {
-      let hasAgreed = get(this, 'hasAgreed');
-      if (hasAgreed) {
-        this.set('agreementError', null);
-      } else {
-        this.set('agreementError', {message: 'please accept the Terms of Use'})
-      }
+      // delay one tick to ensure click event (update checkbox)
+      // registers before change event (validate checkbox)
+      // order of events firing can vary between browsers
+      next(() => {
+        if (this.get("isDestroyed")) {
+          return;
+        }
+        let hasAgreed = get(this, 'hasAgreed');
+        if (hasAgreed) {
+          this.set('agreementError', null);
+        } else {
+          this.set('agreementError', {message: 'please accept the Terms of Use'})
+        }
+      });
     }
   }
 });

tests/acceptance/audio-survey-test.js

@@ -119,6 +119,7 @@ test('taking an audio survey', function(assert) {
   });
 
   andThen(function() {
+    assert.equal(find('.personal-info__errors').length, 0, 'no error messages should be visible after filling form');
     assert.equal(find('.personal-info__submit.disabled').length, 0, 'submit button should not have disabled style after filling form');
     click('.personal-info__submit');
   });