-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to latest API version - added LicenceKey parameter #29
base: master
Are you sure you want to change the base?
Conversation
It looks like the required field was already present on LGTM apart from a minor gofmt |
@cryptix do you need me to reformat/change some things before merging? |
May I ping this merge request? I would like to see this working again 😄 |
POLL_CREATE_MESSAGE MsgType = 0x15 //indicates a poll message | ||
POLL_VOTE_MESSAGE MsgType = 0x16 //indicates a poll message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see why underlines are more readable but I'd personally prefer to have them all in the same pattern.
Not sure how noisy it would be to change them all. Maybe as a follow-up?
@fabiogermann I will try to make a call with corrupt and willnix before xmas or after. we'd usually would have met over c3 but not sure who of us will be there remote this year. Personally I'd add you right away but maybe we should have quick temperature check and clear up understandings. For example I'd prefer to have at least 2 additional eyes on a PR before merging. |
As the current version of the API is not supported the creation of a NEW identity is not possible anymore. The following error is the result: o3ma/o3rest#2
Using the updated API and a license from the theema store (shop.threema.ch) it works again.
Also see: o3ma/o3rest#3