[WIP] TWW Support #678
Merged
[WIP] TWW Support #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls-
added
element
expansion
next major
ls-
changed the title
|
K, after a heated discussion we decided to move it to the health element. |
It's needed due to the nature of the element, but if layout devs want to do something else they can always override the whole thing 😵
|
K, this PR is now the TWW PR, all the TWW-related work will be happening here. I won't be renaming the git branch, it's whatever 😒 |
For now... 😵
Again... But this time around it should actually work 😅
ls-
commented
Jul 16, 2024
| local ALT_POWER_BAR_PAIR_DISPLAY_INFO = _G.ALT_POWER_BAR_PAIR_DISPLAY_INFO | ||
|
|
There was a problem hiding this comment.
Why did you add an empty line here tho?
| local SPEC_MAGE_ARCANE = _G.SPEC_MAGE_ARCANE or 1 | ||
| local SPEC_MONK_WINDWALKER = _G.SPEC_MONK_WINDWALKER or 3 | ||
| local SPEC_WARLOCK_DESTRUCTION = _G.SPEC_WARLOCK_DESTRUCTION or 3 | ||
|
|
| local ALTERNATE_POWER_INDEX = Enum.PowerType.Alternate or 10 | ||
|
|
| local ALT_POWER_BAR_PAIR_DISPLAY_INFO = _G.ALT_POWER_BAR_PAIR_DISPLAY_INFO | ||
|
|
p3lim
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TWW Blizz added this new thingy, the temporary max health loss bar.
In this pic the max health was reduced by 50%, but the player is still at 100% health, it's just the total available amount of hp that's reduced temporarily, my assumption so far is that it's due to some raid/dungeon mechanics/auras hence the "temporary" bit in its name. This bar is kinda similar to "Reserved Life" from Path of Exile.