Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power: Add support for atlas textures #694

Merged
merged 5 commits into from
Dec 1, 2024
Merged

power: Add support for atlas textures #694

merged 5 commits into from
Dec 1, 2024

Conversation

p3lim
Copy link
Member

@p3lim p3lim commented Nov 20, 2024

No description provided.

@p3lim p3lim requested a review from ls- November 20, 2024 23:43
@p3lim p3lim self-assigned this Nov 20, 2024
kodewdle added a commit to tukui-org/ElvUI that referenced this pull request Nov 21, 2024
Copy link
Member

@ls- ls- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@p3lim
Copy link
Member Author

p3lim commented Nov 30, 2024

This needs to revert to the previously used texture when switching back to not using an atlas, otherwise the atlas texture would be used for colors (e.g. switching between moonkin form and cat form as a balance druid).

Unsure if we want to cache the texture set on enable, or to provide an option to specify one. The former would be nicer for the user.

@p3lim
Copy link
Member Author

p3lim commented Nov 30, 2024

Also think the option name should be more verbose, maybe colorPowerAtlas?

@ls-
Copy link
Member

ls- commented Nov 30, 2024

No. Why? It's on the .Power element. frame.Power.usePowerAtlas would be overly verbose.

@p3lim
Copy link
Member Author

p3lim commented Nov 30, 2024

No. Why? It's on the .Power element. frame.Power.usePowerAtlas would be overly verbose.

Since this option is essentially the equivalent to coloring the status bar it makes sense that the option is named as such.

@ls-
Copy link
Member

ls- commented Nov 30, 2024

Since this option is essentially the equivalent to coloring the status bar it makes sense that the option is named as such.

Nah.

ls-

This comment was marked as outdated.

elements/power.lua Outdated Show resolved Hide resolved
elements/power.lua Outdated Show resolved Hide resolved
elements/power.lua Outdated Show resolved Hide resolved
Copy link
Member

@ls- ls- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@p3lim p3lim merged commit 69b0819 into master Dec 1, 2024
1 check passed
@p3lim p3lim deleted the power-atlas branch December 1, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants