-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
power: Add support for atlas textures #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏼
This needs to revert to the previously used texture when switching back to not using an atlas, otherwise the atlas texture would be used for colors (e.g. switching between moonkin form and cat form as a balance druid). Unsure if we want to cache the texture set on enable, or to provide an option to specify one. The former would be nicer for the user. |
Also think the option name should be more verbose, maybe |
No. Why? It's on the |
Since this option is essentially the equivalent to coloring the status bar it makes sense that the option is named as such. |
Nah. |
Clarified this on Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏼
No description provided.