Conversation
- Use newer actions - Add permissions for OST Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Update golang-ci config file to v2. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Make it possible to update more VM properties. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Refactor a bit to avoid duplicate code between vm_create and vm_update. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Update oVirt GO SDK to 4.5.0. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Fix all the error that where thrown by the updated linter. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
Make some changes in Update VM to be able to update more VM settings via Terraform.
Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
Yes