New application entity (v0.3.0) #447

dhiguero · 2021-04-12T18:59:25Z

What does this PR do?

Updates the specification of the Application entity according to the v0.3.0 spec proposal.

Where should the reviewer start?

Review 7.application.md for most changes.

What is missing?

Any background context you want to provide?

What are the associated tickets?

Questions

Section Component instances and revisions of component has been updated with components, but this is closely related to how the runtime is expected to operate. Is this still the intended behavior? I think it is necessary to create a component instance since we are referencing components by type and assigning them a new name, which I suppose will be used to name the component instance.

ghost · 2021-04-12T18:59:37Z

All CLA requirements met.

ghost · 2021-04-12T18:59:37Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ dhiguero sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

hongchaodeng

lgtm after nit

7.application.md

hongchaodeng · 2021-04-12T22:30:04Z

7.application.md

-In practice, the available workload types are registered by infrastructure operators/platform builders to the platform following OAM specification. They are explained in detail in this chapter: [workload definition](4.workload_types.md).
+A component may define a set of parameters that can be modified for each particular instance.
+
+ upon instanciation. 


What's this line?

7.application.md

hongchaodeng · 2021-04-13T17:45:09Z

7.application.md

      traits:
-        - name: scaler
+        - name: ingress # ingress trait providing a public endpoint for the publicweb component of the application.


Maybe leave a comment here indicating that the name of the trait will be the same as the component?

Co-authored-by: Hongchao Deng <[email protected]> Co-authored-by: Jianbo Sun <[email protected]> Co-authored-by: Lei Zhang (Harry) <[email protected]>

dhiguero · 2021-04-15T19:03:09Z

Hi! I have been testing deploying an Application in Kubevela following the proposed changes and it seems that there is a mismatch related to how scopes are specified. In the previous version, we used a scopeRef as:

      scopes:
        - scopeRef:
            apiVersion: core.oam.dev/v1alpha2
            kind: HealthScope
            name: app-health # An application level health scope including both components.

However it seems that the new runtime expects a map as:

      scopes:
        "healthscopes.core.oam.dev": "app-health"

@resouer, @hongchaodeng Could you please check which one is the expected one? I will update the example accordingly before merging the PR.

wonderflow · 2021-04-21T03:49:35Z

In application, I hope we can use this way as it's more convenient:

      scopes:
        "healthscopes.core.oam.dev": "app-health"

The healthscopes.core.oam.dev will refer to a ScopeDefinition which will refer to the information:

            apiVersion: core.oam.dev/v1alpha2
            kind: HealthScope

resouer · 2021-04-24T18:10:18Z

+1 to @wonderflow 's approach. Note that this also implies the ScopeDefinition is named as healthscopes.core.oam.dev and references the real resource schema (HealthScope GVK), similar to workload definition.

dhiguero · 2021-04-26T13:31:01Z

@resouer , @wonderflow I have uploaded the changes related to the scope.

7.application.md

dhiguero · 2021-04-27T07:28:16Z

New revision available. Thanks @kminder for the awesome review.

kminder

Approved

wonderflow

Thanks, great job!

dhiguero added 2 commits April 12, 2021 20:50

New application entity

5762784

Fix version

9a4755a

dhiguero requested review from hongchaodeng, resouer, technosophos and vturecek as code owners April 12, 2021 18:59

dhiguero changed the title ~~New application entity~~ New application entity (v0.3.0) Apr 12, 2021

hongchaodeng approved these changes Apr 12, 2021

View reviewed changes

wonderflow reviewed Apr 13, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

wonderflow reviewed Apr 13, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

wonderflow reviewed Apr 13, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

resouer reviewed Apr 13, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

hongchaodeng reviewed Apr 13, 2021

View reviewed changes

dhiguero and others added 2 commits April 15, 2021 20:51

Apply suggestions from code review

d7950f1

Co-authored-by: Hongchao Deng <[email protected]> Co-authored-by: Jianbo Sun <[email protected]> Co-authored-by: Lei Zhang (Harry) <[email protected]>

Apply comments and suggestions from PR

61e7fb4

resouer added this to the v0.3.0 milestone Apr 25, 2021

dhiguero added 2 commits April 26, 2021 15:21

Fix scope reference

a7060de

Merge master

6772357

Fix merge

22f50b8

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

kminder reviewed Apr 26, 2021

View reviewed changes

7.application.md Outdated Show resolved Hide resolved

Address PR comments

1113f1f

kminder approved these changes Apr 27, 2021

View reviewed changes

wonderflow approved these changes Apr 28, 2021

View reviewed changes

resouer merged commit 9ce53b6 into oam-dev:master Apr 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New application entity (v0.3.0) #447

New application entity (v0.3.0) #447

dhiguero commented Apr 12, 2021 •

edited

Loading

ghost commented Apr 12, 2021 •

edited by ghost

Loading

ghost commented Apr 12, 2021

hongchaodeng left a comment

hongchaodeng Apr 12, 2021

hongchaodeng Apr 13, 2021

dhiguero commented Apr 15, 2021

wonderflow commented Apr 21, 2021

resouer commented Apr 24, 2021 •

edited

Loading

dhiguero commented Apr 26, 2021

dhiguero commented Apr 27, 2021

kminder left a comment

wonderflow left a comment

New application entity (v0.3.0) #447

New application entity (v0.3.0) #447

Conversation

dhiguero commented Apr 12, 2021 • edited Loading

What does this PR do?

Where should the reviewer start?

What is missing?

Any background context you want to provide?

What are the associated tickets?

Questions

ghost commented Apr 12, 2021 • edited by ghost Loading

ghost commented Apr 12, 2021

hongchaodeng left a comment

Choose a reason for hiding this comment

hongchaodeng Apr 12, 2021

Choose a reason for hiding this comment

hongchaodeng Apr 13, 2021

Choose a reason for hiding this comment

dhiguero commented Apr 15, 2021

wonderflow commented Apr 21, 2021

resouer commented Apr 24, 2021 • edited Loading

dhiguero commented Apr 26, 2021

dhiguero commented Apr 27, 2021

kminder left a comment

Choose a reason for hiding this comment

wonderflow left a comment

Choose a reason for hiding this comment

dhiguero commented Apr 12, 2021 •

edited

Loading

ghost commented Apr 12, 2021 •

edited by ghost

Loading

resouer commented Apr 24, 2021 •

edited

Loading