Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1293] Automatically assign pytest markers, ignore warnings #1275

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented Jun 21, 2024

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@danmyway danmyway added no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests-run-sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Jun 21, 2024
@has-bot
Copy link
Member

has-bot commented Jun 21, 2024

/packit test --labels sanity


Comment generated by an automation.

@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch from daae7bf to cd4f3dc Compare June 21, 2024 11:06
@danmyway
Copy link
Member Author

/packit test --labels sanity

@kokesak
Copy link
Member

kokesak commented Jul 1, 2024

/packit build

@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch from cd4f3dc to fe76290 Compare July 2, 2024 12:31
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (a69b222) to head (c25988a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          55       55           
  Lines        4756     4756           
  Branches      836      836           
=======================================
  Hits         4558     4558           
  Misses        112      112           
  Partials       86       86           
Flag Coverage Δ
centos-linux-7 91.02% <ø> (ø)
centos-linux-8 91.95% <ø> (ø)
centos-linux-9 92.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danmyway
Copy link
Member Author

danmyway commented Jul 3, 2024

/packit test

@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch 2 times, most recently from efd0012 to b1cff4e Compare July 3, 2024 09:44
@danmyway
Copy link
Member Author

danmyway commented Jul 3, 2024

/packit test

@danmyway
Copy link
Member Author

danmyway commented Jul 3, 2024

/packit test --labels centos

@danmyway
Copy link
Member Author

danmyway commented Jul 3, 2024

/packit test --labels oracle-7

@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch from b1cff4e to 2413f58 Compare July 3, 2024 12:46
@danmyway
Copy link
Member Author

danmyway commented Jul 3, 2024

/packit test

@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch 2 times, most recently from f2f814f to 8cd11dd Compare July 4, 2024 13:15
@kokesak
Copy link
Member

kokesak commented Jul 10, 2024

rebase and rerun please, otherwise looking good

@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch from 8cd11dd to 1151c9b Compare July 10, 2024 13:47
@kokesak
Copy link
Member

kokesak commented Jul 10, 2024

/packit test

1 similar comment
@danmyway
Copy link
Member Author

/packit test

* assign pytest markers automatically
  *
* ignore PytestUnknownWarning on custom markers starting with test_
* modify metadata treflect the markers
* remove a te tests

Signed-off-by: Daniel Diblik <[email protected]>
@danmyway danmyway force-pushed the tests-ignore-pytest-warnings branch from 1151c9b to c25988a Compare July 17, 2024 13:10
@danmyway
Copy link
Member Author

/packit test

@danmyway danmyway requested a review from kokesak July 18, 2024 05:13
@danmyway danmyway enabled auto-merge (squash) July 18, 2024 05:19
Copy link
Member

@kokesak kokesak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danmyway danmyway merged commit d56602a into oamg:main Jul 22, 2024
61 checks passed
@danmyway danmyway deleted the tests-ignore-pytest-warnings branch September 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests-run-sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants