[RHELC-1747] Use enablerepo instead of no_rhsm to check custom repos #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 71 71
Lines 5077 5078 +1
Branches 883 883
=======================================
+ Hits 4900 4901 +1
Misses 98 98
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bocekm
previously requested changes
Jul 3, 2024
r0x0d
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
from
bcdb1b0
to
619c7fa
Compare
pr-watson
reviewed
Aug 6, 2024
convert2rhel/actions/pre_ponr_changes/custom_repos_are_valid.py
Outdated
Show resolved
Hide resolved
r0x0d
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
3 times, most recently
from
0cbbeed
to
64c1e91
Compare
r0x0d
added
bug-fix
r0x0d
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
from
64c1e91
to
8ba6221
Compare
r0x0d
added
tests-run-sanity
r0x0d
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
from
8ba6221
to
702293d
Compare
r0x0d
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
from
702293d
to
db2f0ec
Compare
|
/packit test --labels sanity |
r0x0d
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
from
db2f0ec
to
d652726
Compare
hosekadam
approved these changes
Oct 1, 2024
We were using the no_rhsm option to skip the check for custom repositories, and since the system can be unregistered or pre-registered, there is no need anymore to use no_rhsm in this action, instead, we can use enablerepo directly to validate if the repositories are valid or not.
Moving the CustomReposAreValid to pre_ponr_changes to be a dependency of SUBSCRIBE_SYSTEM.
Venefilyn
force-pushed
the
use-enablerepos-instead-of-no-rhsm
branch
from
d652726
to
fdb8942
Compare
|
/packit test --labels sanity |
Venefilyn
dismissed
bocekm’s stale review
From Adam: The problem Michal mentioned is fixed, the changes looks good.
|
@r0x0d can you create a Jira issue, update the PR text, and merge? |
r0x0d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the no_rhsm option to skip the check for custom repositories, and since the system can be unregistered or pre-registered, there is no need anymore to use no_rhsm in this action, instead, we can use enablerepo directly to validate if the repositories are valid or not.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevantTODO