Tests #828
Tests #828
Conversation
- addresses parts of oasis-tcs#824 - add missing `$schema` to testdata schema for CSAF 2.1 - disallow additional properties for CSAF 2.1
- addresses parts of oasis-tcs#824 - add missing `$schema` to testdata schema for CSAF 2.0 - disallow additional properties for CSAF 2.0
tschmidtb51
added
csaf 2.0
| @@ -79,10 +79,20 @@ | |||
| } | |||
| }, | |||
| "required": [ | |||
| "$schema", | |||
There was a problem hiding this comment.
In general this is ok for me, since this is also a test file, one just needs to be aware of that specifying the $schema as a property is not really "recommended" or specified by the standard.
Although it is used by many editors (see VSCode https://code.visualstudio.com/docs/languages/json#_mapping-in-the-json) there is no official statement from the specification on that (see https://github.com/orgs/json-schema-org/discussions/473). In the fact the discussion there did not end with any conclusion at all.
I will conduct a small test, whether this actually works at least with the 2 JSON schema generator libraries that we use
There was a problem hiding this comment.
@oxisto Could you please double check that the JSON schema spec does not prohibit the use of $schema in a JSON instance and as defined in the JSON schema. (This might have an impact on #616.)
At the moment, I don't see another way to make sure the location of the schema is known other than to declare which schema should be used to validate ...
$schematotestcases_json_schema.json#824$schemato testdata schema for CSAF 2.1$schemato testdata schema for CSAF 2.0