Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show a second 'Transactions' in the transactions row #491

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jun 12, 2023

Comment from @donouwens:

It feels rather redundant to have the 'Transactions' row read {n} transactions. I'd prefer to not see the second 'transactions', like in the visual:
https://www.figma.com/file/ifCrok8cP5ymEYjMa2PIi9/MVP?type=design&node-id=2457%3A160463&t=bEknLFapsrD4SC6U-1

Current state:
Screenshot 2023-06-09 at 17 11 30

@csillag csillag requested review from lukaw3d and buberdds June 12, 2023 10:16
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Deployed to Cloudflare Pages

Latest commit: 6d77bb919e21a56e7745fb3a618f07a95fd8db56
Status:✅ Deploy successful!
Preview URL: https://45fe9f1e.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/no-double-transactions-label branch 3 times, most recently from 1a98d81 to 09cdaa0 Compare June 12, 2023 15:41
@csillag csillag requested a review from lubej June 12, 2023 15:45
@csillag csillag force-pushed the csillag/no-double-transactions-label branch from 09cdaa0 to 6d77bb9 Compare June 12, 2023 15:55
@csillag csillag requested a review from buberdds June 12, 2023 15:55
@csillag csillag merged commit 58164a8 into master Jun 12, 2023
@csillag csillag deleted the csillag/no-double-transactions-label branch June 12, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants