Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile ticks #511

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Add mobile ticks #511

merged 1 commit into from
Jun 14, 2023

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Jun 13, 2023

No description provided.

@lubej
Copy link
Collaborator Author

lubej commented Jun 13, 2023

[General] Transaction Charts abbreviate number on y-axis
I'd like to suggest abbreviating the number on the y-axis of both transaction charts as these figures are very large.

My proposal is to abbreviate to millions (e.g. 20000000 ➝ 20M)
Screenshot 2023-06-09 at 15 27 43

See updated chart visuals: /Link not public/

@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Deployed to Cloudflare Pages

Latest commit: fc0e4185ec81ace674454710a19c9432d28cf7cf
Status:✅ Deploy successful!
Preview URL: https://d0a9976a.oasis-explorer.pages.dev

@lubej lubej requested review from buberdds and csillag June 13, 2023 10:27
src/index.tsx Outdated Show resolved Hide resolved
src/app/components/charts/LineChart.tsx Outdated Show resolved Hide resolved
@lubej lubej force-pushed the ml/chart-abbreviate-numbers branch from 9cc5274 to 3086c88 Compare June 13, 2023 15:01
@buberdds buberdds force-pushed the ml/chart-abbreviate-numbers branch from 3086c88 to fc0e418 Compare June 14, 2023 08:54
@buberdds buberdds merged commit c41f5b7 into master Jun 14, 2023
@buberdds buberdds deleted the ml/chart-abbreviate-numbers branch June 14, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants