Round token supply number in token list #703
Conversation
Deployed to Cloudflare Pages
|
| @@ -129,7 +130,7 @@ export const TokenList = (props: TokensProps) => { | |||
| align: TableCellAlign.Right, | |||
| }, | |||
| { | |||
| content: token.total_supply, | |||
| content: <RoundedBalance value={token.total_supply} ticker={token.symbol} />, | |||
There was a problem hiding this comment.
Actually I prefer this way of formatting the supply: https://github.com/oasisprotocol/explorer/blob/master/src/locales/en/translation.json#L215
With rounded balance:
Via i18next:
There was a problem hiding this comment.
But I also understand that it is not great with decimals.
I think we need a way that satisfies both criteria.
Can we have the same grouping in RoundedBalance?
(Also, maybe we could consider to resurrect #333?)
There was a problem hiding this comment.
Looking at task for now we care about decimals only. Prob Don will revisit it all later. i18n does not match logic in RoundedDecimals.
There was a problem hiding this comment.
Ok, I think we are good here. As discussed during meeting, RoundedBalance logic will be adjusted in another PR.
Token supply has too many decimal points