Precisely format large numbers using Intl through i18n #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
commented
Jul 27, 2023
lukaw3d
force-pushed
the
lw/format-intl
branch
3 times, most recently
from
01b82a1 to
ab211c1
Compare
lukaw3d
commented
Aug 3, 2023
Comment on lines
+53
to
+80
| test.describe('getPreciseNumberFormat', () => { | ||
| test('small number should be precise and formatted', async ({ page }) => { | ||
| await setup(page, '111222333444555', 9) | ||
| // Expect precisely formatted small number even when browser doesn't support precise formatting for large numbers | ||
| await expect(page.getByText('111,222.333444555', { exact: true })).toBeVisible() | ||
| }) | ||
|
|
||
| test('large number should be precise and formatted or fallback to precise unformatted number in browsers without support', async ({ | ||
| page, | ||
| }) => { | ||
| await setup(page, '111222333444555666777888999111222333444555666', 18) | ||
| await expect( | ||
| page | ||
| .getByText('111,222,333,444,555,666,777,888,999.111222333444555666', { exact: true }) | ||
| // Expect precise fallback when browser doesn't support precise formatting | ||
| .or(page.getByText('111222333444555666777888999.111222333444555666', { exact: true })), | ||
| ).toBeVisible() | ||
| }) | ||
|
|
||
| test('exceeding maximumFractionDigits:20 should fallback to precise unformatted number', async ({ | ||
| page, | ||
| }) => { | ||
| await setup(page, '111222333444555666777888999111222333444555666', 36) | ||
| await expect( | ||
| page.getByText('111222333.444555666777888999111222333444555666', { exact: true }), | ||
| ).toBeVisible() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
How it behaves across browsers
@donouwens says "Yeah, I think this should work. 👍"
lukaw3d
commented
Aug 3, 2023
Comment on lines
97
to
+101
| "value": "Value", | ||
| "valueInToken": "{{value}} {{ticker}}", | ||
| "roundedValueInToken": "{{value}}… <TickerLink />", | ||
| "valueInTokenWithLink": "{{value}} <TickerLink />", | ||
| "valueLong": "{{value, number}}", | ||
| "valueInToken": "{{value, number}} {{ticker}}", | ||
| "roundedValueInToken": "{{value, number}}… <TickerLink />", | ||
| "valueInTokenWithLink": "{{value, number}} <TickerLink />", |
There was a problem hiding this comment.
I don't know how to better name these and lessThanAmount and valuePair. Future issue?
lukaw3d
commented
Aug 3, 2023
| // Firefox 115 and Safari 16.5 return '111,222,333,444,555,670,000,000,000' | ||
| .at(-1) === '6' | ||
|
|
||
| export function getPreciseNumberFormat(value: string) { |
There was a problem hiding this comment.
Also open for name suggestions
lukaw3d
commented
Aug 3, 2023
| "valueInToken": "{{value}} {{ticker}}", | ||
| "roundedValueInToken": "{{value}}… <TickerLink />", | ||
| "valueInTokenWithLink": "{{value}} <TickerLink />", | ||
| "valueLong": "{{value, number}}", |
There was a problem hiding this comment.
Here's what happens if we add a language switcher:
| English | French |
|---|---|
 |
 |
lukaw3d
changed the title
lukaw3d
changed the title
csillag
approved these changes
Aug 7, 2023
In browsers with imprecise Intl.NumberFormat: display unformatted original string instead of implicitly being converted to rounded float.
In browsers with imprecise Intl.NumberFormat: display formatted number after allowing implicit conversion to rounded float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to / opposite of #333
Consistently format even large stringified numbers using native Intl
TODO: replace all toLocaleString and
<span>{param.value as string}</span>