TX details: support switching between hex and base64 data display #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/data-format-switch
branch
from
61ba33b to
2f11454
Compare
|
I propose we use the existing Oasis<->ETH toggle for switching between Oasis and ETH format. The intuition is the following:
|
csillag
force-pushed
the
csillag/data-format-switch
branch
from
2f11454 to
0720c0b
Compare
|
A friendly reminder: this is still waiting for feedback from @donouwens |
|
@csillag this makes sense to me so let's make it happen, please. Do you need any visuals from me on this? |
|
Could you please check the current implementation? |
|
@donouwens I think we should discuss this a bit more, since after I implemented it, @matevz has explained that he has actually meant something different... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. as requested by @matevz
More design feedback is needed by @donouwens .