storage: omitempty nodeapi.Event alternates #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
reviewed
Nov 30, 2024
| GovernanceProposalExecuted *ProposalExecutedEvent | ||
| GovernanceProposalFinalized *ProposalFinalizedEvent | ||
| GovernanceVote *VoteEvent | ||
| StakingTransfer *TransferEvent `json:",omitempty"` |
There was a problem hiding this comment.
It looks like we used to have the omitempty annotations here and removed them in 02df003 (by mistake?).
Should we also add them back in other places that were removed (e.g. VRFPubKey field)
There was a problem hiding this comment.
@Andrew7234 how did those json annotations come up in the api tests PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeapi.Event, used in many consensus source storage APIs, get serialized to cache with all these fields having explicit nulls. that increases the sensitivity to field changes. for example, many events cached from the cobalt upgrade had
RegistryRuntimeRegistered= null, which causes the deserialization to fail, on events that aren't even related to the registry.