add cpu/memory profiling draft #796
Draft
+81
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
reviewed
Nov 30, 2024
| // Initialize cpu profiling. | ||
| if cfg.Metrics.CpuProfile != "" { | ||
| logger.Warn("CPU profiling is enabled, this will impact performance (negatively)", "dest", cfg.Metrics.CpuProfile) | ||
| cpuF, err := os.Create(cfg.Metrics.CpuProfile) |
There was a problem hiding this comment.
Can we instead add pprof.address (or similar) config parameter. Then if set, we start the pprof server on the provided address?
That is more generic and covers more profiling cases, since the user has more control over the profiling setup. That's the way we have it done in other projects, for example web3-gateway and oasis-core, and it tends to work pretty well in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging purposes