Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/rofl: Rewrite ROFL docs to use TDX containers #2153

Merged
merged 1 commit into from
Feb 20, 2025
Merged

docs/rofl: Rewrite ROFL docs to use TDX containers #2153

merged 1 commit into from
Feb 20, 2025
+486 −597

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 13, 2025

Closes #2149

@netlify Netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

❌ Deploy Preview for oasisprotocol-oasis-sdk failed.

Name Link
🔨 Latest commit 9dbe6d7
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/67b5ed64151f800008c70a25

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.88%. Comparing base (b4a8d86) to head (0c3376e).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
- Coverage   59.06%   58.88%   -0.18%     
==========================================
  Files         142      144       +2     
  Lines       10089    10172      +83     
==========================================
+ Hits         5959     5990      +31     
- Misses       4130     4182      +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers-docs branch from 0c3376e to 62db9a5 Compare February 17, 2025 12:40
@kostko kostko mentioned this pull request Feb 18, 2025
Merged
@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers-docs branch 4 times, most recently from 4a77dd7 to 535d2da Compare February 19, 2025 10:04
@kostko kostko marked this pull request as ready for review February 19, 2025 10:04
ptrus
ptrus reviewed Feb 19, 2025
View reviewed changes
docs/rofl/app.mdx
checking out the [prepared example project] from the Oasis SDK repository. It
contains a simple [Oracle.sol] contract which collects observations from
authenticated ROFL app instances, performs trivial aggregation and stores the
final aggregated result. Read the [Sapphire quickstart] chapter to learn how to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a question for sapphire/ @matevz. We use hardhat in this guide, and I see that the "Sapphire quickstart" also uses hardhat. I thought foundry was the cool thing to use with Sapphire these days.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied over from the old ROFL tutorial. Not sure if anything has changed here.

ptrus
ptrus reviewed Feb 19, 2025
View reviewed changes
ptrus
ptrus reviewed Feb 19, 2025
View reviewed changes
ptrus
ptrus reviewed Feb 19, 2025
View reviewed changes
ptrus
ptrus approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, otherwise looks very good to me! 👍

@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers-docs branch from 535d2da to 9dbe6d7 Compare February 19, 2025 14:40
@kostko kostko merged commit f44fc72 into main Feb 20, 2025
25 of 26 checks passed
@kostko kostko deleted the kostko/feature/rofl-tdx-containers-docs branch February 20, 2025 12:14
github-actions bot added a commit that referenced this pull request Feb 20, 2025
@github-actions
Deploy js API reference Merge pull request #2153 from oasisprotocol/k…
1703725 
…ostko/feature/rofl-tdx-containers-docs

docs/rofl: Rewrite ROFL docs to use TDX containers f44fc72
github-actions bot added a commit that referenced this pull request Feb 20, 2025
@github-actions
Deploy rust API reference Merge pull request #2153 from oasisprotocol…
654d6e7 
…/kostko/feature/rofl-tdx-containers-docs

docs/rofl: Rewrite ROFL docs to use TDX containers f44fc72
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Feb 20, 2025
@github-actions
Deploy js API reference Merge pull request oasisprotocol#2153 from oa…
4cf064c 
…sisprotocol/kostko/feature/rofl-tdx-containers-docs

docs/rofl: Rewrite ROFL docs to use TDX containers f44fc72
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Feb 20, 2025
@github-actions
Deploy rust API reference Merge pull request oasisprotocol#2153 from …
2246c22 
…oasisprotocol/kostko/feature/rofl-tdx-containers-docs

docs/rofl: Rewrite ROFL docs to use TDX containers f44fc72
@matevz matevz mentioned this pull request Mar 6, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrus ptrus ptrus approved these changes

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@peternose peternose Awaiting requested review from peternose peternose is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite ROFL docs to showcase TDX containers
2 participants
@kostko @ptrus