Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofl: Add Apps query and emit event on instance registration #2159

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Feb 18, 2025

Fixes: #2158 #2157

@kostko kostko linked an issue Feb 18, 2025 that may be closed by this pull request
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit 722231c
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/67b59262a1f05b0008ed8e39

@ptrus ptrus force-pushed the ptrus/feature/rofl-apps-instanceregistered branch 3 times, most recently from c8025fe to b69ad65 Compare February 19, 2025 07:32
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.87%. Comparing base (facdbe1) to head (b69ad65).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
runtime-sdk/src/modules/rofl/mod.rs 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2159      +/-   ##
==========================================
- Coverage   58.88%   58.87%   -0.01%     
==========================================
  Files         144      144              
  Lines       10172    10187      +15     
==========================================
+ Hits         5990     5998       +8     
- Misses       4182     4189       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptrus ptrus marked this pull request as ready for review February 19, 2025 07:58
@ptrus ptrus requested a review from kostko February 19, 2025 07:58
@ptrus ptrus force-pushed the ptrus/feature/rofl-apps-instanceregistered branch from b69ad65 to 722231c Compare February 19, 2025 08:12
@ptrus ptrus merged commit 39ce172 into main Feb 19, 2025
26 checks passed
@ptrus ptrus deleted the ptrus/feature/rofl-apps-instanceregistered branch February 19, 2025 10:03
github-actions bot added a commit that referenced this pull request Feb 19, 2025
github-actions bot added a commit that referenced this pull request Feb 19, 2025
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Feb 19, 2025
…sisprotocol/ptrus/feature/rofl-apps-instanceregistered 39ce172
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Feb 19, 2025
…oasisprotocol/ptrus/feature/rofl-apps-instanceregistered 39ce172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROFL: Emit event on Instance registration ROFL: Add query to return all applications
3 participants