tools/orc: Add support for ephemeral signer key #2168
Merged
+133
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
peternose
approved these changes
Mar 5, 2025
| // | ||
| // The code below is adopted from the Go standard library as it is otherwise not possible to | ||
| // customize the exponent. | ||
| func sgxGenerateKey(random io.Reader) (*rsa.PrivateKey, error) { |
There was a problem hiding this comment.
Should we add some kind of test, e.g. to test that e == 3, bits == 3072, two primes, ...?
| @@ -531,6 +556,84 @@ func showTdxComponent(indent string, bnd *bundle.Bundle, comp *bundle.Component) | |||
| fmt.Printf("%s Memory: %d MiB\n", indent, comp.TDX.Resources.Memory) | |||
| } | |||
|
|
|||
| // sgxGenerateKey generates a 3072-bit RSA key with public exponent 3 as required for SGX. | |||
There was a problem hiding this comment.
I thought that small exponents should be avoided. But if they required 3, then what can you do? 🤷
There was a problem hiding this comment.
It doesn't really matter as MRSIGNER is not used anywhere in our system (we just compare against a reference value in the policy). So it doesn't really matter even if this key is compromised. Which is why we are adding these ephemeral keys here.
github-actions bot
added a commit
that referenced
this pull request
Mar 5, 2025
…ostko/feature/orc-sgx-setsig-rngkey fc4b55e
github-actions bot
added a commit
that referenced
this pull request
Mar 5, 2025
…/kostko/feature/orc-sgx-setsig-rngkey fc4b55e
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Mar 5, 2025
…sisprotocol/kostko/feature/orc-sgx-setsig-rngkey fc4b55e
github-actions bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Mar 5, 2025
…oasisprotocol/kostko/feature/orc-sgx-setsig-rngkey fc4b55e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2167