Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reversion with custom errors & maximum view call size #196

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

CedarMist
Copy link
Member

@CedarMist CedarMist commented Sep 28, 2023

No description provided.

@CedarMist CedarMist self-assigned this Sep 28, 2023
@CedarMist CedarMist added p:1 Priority: high contracts Pull requests that update sapphire-contracts labels Sep 28, 2023
@CedarMist
Copy link
Member Author

This has been tested on sapphire-testnet & locally with an un-borked version of sapphire-dev.

Currently it fails on testnet without oasisprotocol/oasis-web3-gateway#468

@CedarMist CedarMist marked this pull request as ready for review October 24, 2023 19:35
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, othwerwise lgtm.

contracts/test/semantics.ts Outdated Show resolved Hide resolved
contracts/hardhat.config.ts Outdated Show resolved Hide resolved
@CedarMist CedarMist force-pushed the CedarMist/tests/reverts-and-size branch from 36b9033 to 45f15cd Compare October 30, 2023 17:01
contracts/hardhat.config.ts Show resolved Hide resolved
@CedarMist CedarMist merged commit b216916 into main Oct 30, 2023
14 checks passed
@CedarMist CedarMist deleted the CedarMist/tests/reverts-and-size branch October 30, 2023 20:54
github-actions bot added a commit that referenced this pull request Oct 30, 2023
…edarMist/tests/reverts-and-size

Test reversion with custom errors & maximum view call size b216916
github-actions bot added a commit that referenced this pull request Oct 30, 2023
…darMist/tests/reverts-and-size

Test reversion with custom errors & maximum view call size b216916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Pull requests that update sapphire-contracts p:1 Priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants