Fix Go client contract deployment

[aefhm]

Description

PackSignedCall is part of the deployment flow and needs to support the case where msg.To is nil.

sapphire-paratime/clients/go/compat.go

Lines 90 to 97 in 5d6b79e

	func PackSignedCall(msg ethereum.CallMsg, cipher Cipher, sign SignerFn, chainID big.Int, leash *evm.Leash) (*ethereum.CallMsg, error) {
	if msg.Gas == 0 {
	msg.Gas = DefaultGasLimit // Must be non-zero for signed calls.
	}
	if msg.GasPrice == nil {
	msg.GasPrice = big.NewInt(DefaultGasPrice) // Must be non-zero for signed calls.
	}
	dataPack, err := evm.NewSignedCallDataPack(rsvSigner{sign}, chainID.Uint64(), msg.From[:], msg.To[:], msg.Gas, msg.GasPrice, msg.Value, msg.Data, *leash)

TODO

• Publish new Go client.
• Test new Go client.
• Compare against Python client.

[netlify]

✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name	Link
🔨 Latest commit	7ed30b5
🔍 Latest deploy log	https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66466fd6d22d55000880dbea
😎 Deploy Preview	https://deploy-preview-315--oasisprotocol-sapphire-paratime.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[matevz]

The app crashes when you want to deploy a contract with an encrypted transaction right? We're using this go-client library in network-monitoring, but we didn't encounter any crashes, probably because we use the unwrapped version of the eth client for the contract deployment.

Can you also please fix the linting issues while you're at it.

[aefhm]

The app crashes when you want to deploy a contract with an encrypted transaction right?

I'm using plain. 🤔

probably because we use the unwrapped version of the eth client for the contract deployment.

Which version of the client?

[aefhm]

I think my QA issues are independent of this client patch.

[aefhm]

@kostko new release to clients/go/v0.11.2 please?

[kostko]

Done.