-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sapphire-contracts: Add EIP-4361 SIWE parser and base contract #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
9411e94
to
b3bf4d0
Compare
b3bf4d0
to
726e800
Compare
b028bb7
to
aeac833
Compare
aefhm
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clear test cases!
aefhm
reviewed
Jul 18, 2024
aefhm
reviewed
Jul 19, 2024
aefhm
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments aren't blocking.
aeac833
to
2bb9f58
Compare
0117269
to
97efc78
Compare
97efc78
to
679fc0e
Compare
github-actions bot
added a commit
that referenced
this pull request
Jul 19, 2024
…tevz/sapphire-contracts-auth sapphire-contracts: Add EIP-4361 SIWE parser and base contract ff1b8f9
github-actions bot
added a commit
that referenced
this pull request
Jul 19, 2024
…atevz/sapphire-contracts-auth sapphire-contracts: Add EIP-4361 SIWE parser and base contract ff1b8f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
This PR:
contracts/SiweParser.sol
, an on-chain parser for SIWE messagescontracts/auth/A13e.sol
, an abstract interface for authenticated queries (an alternative to signed queries which will get deprecated in Add Viem v2 & Wagmi v2 packages, and remove Ethers dependency #303)contracts/auth/SiweAuth.sol
, an on-chain authenticator for SIWE.TODO:
make SiweParser self-contained (merge DateTime into SiweParser?)(this doesn't actually improve anything, just adds clutter)Before (signed queries)
After (on-chain auth)