Merge pull request #2125 from oasisprotocol/lw/old-comments

Remove comments about background page (removed after mv3)

.changelog/2125.trivial.md

@@ -0,0 +1 @@
+Remove comments about background page (removed after mv3)

playwright/tests/extension.spec.ts

@@ -17,7 +17,7 @@ test.describe('The extension popup should load', () => {
     await expect(page.getByRole('link', { name: /Create wallet/i })).toBeVisible()
   })
 
-  test('get state from background page through webext-redux', async ({ page, extensionPopupURL }) => {
+  test('saga is initialized', async ({ page, extensionPopupURL }) => {
     await page.goto(`${extensionPopupURL}/`)
     await page.getByRole('button', { name: /Menu/i }).click()
     await page.getByRole('button', { name: /Dark mode/i }).click()
@@ -96,7 +96,7 @@ test.describe('The extension popup should load', () => {
         .getByRole('button', { name: 'Reload app' })
         .click()
         .catch(e => {
-          // Ignore error. Reloading extension's background page auto-closes its popups.
+          // Ignore error. Reloading extension's runtime auto-closes its popups.
           expect(e.toString()).toContain('Target page, context or browser has been closed')
         })
       await page.close()

src/app/state/persist/saga.ts

@@ -136,12 +136,8 @@ function* resetRootState(action: ReturnType<typeof persistActions.resetRootState
   const unlockedStatus = yield* select(selectUnlockedStatus)
   // Redirect home to prevent infinite loading if user closes unpersisted wallet in another tab.
   if (isActionSynced(action) && unlockedStatus === 'emptyUnpersisted') {
-    // Note: can only redirect in webapp, because saga runs in background page in extension.
-    // TODO: find another way if extension starts supporting multiple popups or tabs
-    // e.g. show "You closed wallet in another tab, click to go home"
-    if (runtimeIs === 'webapp') {
-      yield* call([window.location, window.location.assign], '/')
-    }
+    // Note: requires saga to be running in popup in extension, not in a service worker.
+    yield* call([window.location, window.location.assign], '/')
   }
 }