Merge pull request #2129 from oasisprotocol/lw/translations

Improve translations
oasisprotocol · Mar 3, 2025 · 632c3ba · 632c3ba
2 parents 42031b2 + fbf01be
commit 632c3ba
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 11 deletions.
diff --git a/.changelog/2129.trivial.md b/.changelog/2129.trivial.md
@@ -0,0 +1 @@
+Improve translations
diff --git a/src/app/components/AddEscrowForm/index.tsx b/src/app/components/AddEscrowForm/index.tsx
@@ -43,6 +43,11 @@ export const AddEscrowForm = memo((props: Props) => {
   const ticker = useSelector(selectTicker)
   const isMobile = useContext(ResponsiveContext) === 'small'
   const { onWheel } = usePreventChangeOnNumberInputScroll()
+  const translateValidatorStatus: { [status in Validator['status']]: string } = {
+    active: t('validator.statusActive', 'Active'),
+    inactive: t('validator.statusInactive', 'Inactive'),
+    unknown: t('validator.statusUnknown', 'Unknown'),
+  }
   const delegate = () => {
     dispatch(
       transactionActions.addEscrow({
@@ -59,7 +64,7 @@ export const AddEscrowForm = memo((props: Props) => {
         description: t(
           'account.addEscrow.confirmDelegatingToInactive.description',
           'Status of this validator is {{validatorStatus}}. Your delegation might not generate any rewards.',
-          { validatorStatus: props.validatorStatus },
+          { validatorStatus: translateValidatorStatus[props.validatorStatus] },
         ),
         handleConfirm: delegate,
         isDangerous: true,

diff --git a/src/app/components/ErrorFormatter/index.tsx b/src/app/components/ErrorFormatter/index.tsx
@@ -37,7 +37,7 @@ export function ErrorFormatter(props: Props) {
     [WalletErrors.NoOpenWallet]: t('errors.noOpenWallet', 'No wallet opened'),
     [WalletErrors.USBTransportNotSupported]: t(
       'errors.usbTransportNotSupported',
-      'Current platform does not support WebUSB capability. Try on different platform or browser(preferably Chrome).',
+      'Current platform does not support WebUSB capability. Try on different platform or browser (preferably Chrome).',
     ),
     [WalletErrors.USBTransportError]: t('errors.usbTransportError', 'USB Transport error: {{message}}.', {
       message,

diff --git a/src/app/components/ReclaimEscrowForm/index.tsx b/src/app/components/ReclaimEscrowForm/index.tsx
@@ -130,9 +130,10 @@ export const ReclaimEscrowForm = memo((props: Props) => {
       </Box>
       {shares !== '0' && (
         <Text size="small" data-testid="numberOfShares">
-          {t('account.reclaimEscrow.convertedToShares', 'Corresponding number of gigashares: {{shares}}', {
+          {t('account.reclaimEscrow.convertedToShares', 'Corresponding number of shares: {{shares}}', {
             shares: formatBaseUnitsAsRose(shares),
           })}
+          {t('common.postfixAmountInBillions', 'B')}
         </Text>
       )}
       <TransactionStatus error={error} success={success} />

diff --git a/src/app/components/Transaction/index.tsx b/src/app/components/Transaction/index.tsx
@@ -163,7 +163,7 @@ export function Transaction(props: TransactionProps) {
             i18nKey="account.transaction.addEscrow.received"
             t={t}
             components={{ Amount }}
-            defaults="Received <Amount> delegation in escrow"
+            defaults="Received <Amount/> delegation in escrow"
           />
         ),
       },

diff --git a/src/app/components/TransactionPreview/index.tsx b/src/app/components/TransactionPreview/index.tsx
@@ -46,8 +46,13 @@ export const TransactionPreview = memo((props: Props) => {
       />
       {preview.transaction.type === 'reclaimEscrow' && (
         <PreviewRow
-          label={t('transaction.preview.shares', 'Gigashares')}
-          value={<AmountFormatter amount={preview.transaction.shares} hideTicker />}
+          label={t('transaction.preview.shares', 'Shares')}
+          value={
+            <span>
+              <AmountFormatter amount={preview.transaction.shares} hideTicker />
+              {t('common.postfixAmountInBillions', 'B')}
+            </span>
+          }
         />
       )}
       <PreviewRow

diff --git a/src/app/pages/OpenWalletPage/Features/FromLedger/index.tsx b/src/app/pages/OpenWalletPage/Features/FromLedger/index.tsx
@@ -93,7 +93,7 @@ export function FromLedger({ openLedgerAccessPopup }: SelectOpenMethodProps) {
             <Text size="small" textAlign="center">
               {t(
                 'errors.usbTransportNotSupported',
-                'Current platform does not support WebUSB capability. Try on different platform or browser(preferably Chrome).',
+                'Current platform does not support WebUSB capability. Try on different platform or browser (preferably Chrome).',
               )}
             </Text>
           )}

diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
@@ -18,7 +18,7 @@
     "loading": "Loading account",
     "loadingError": "Couldn't load account.",
     "reclaimEscrow": {
-      "convertedToShares": "Corresponding number of gigashares: {{shares}}",
+      "convertedToShares": "Corresponding number of shares: {{shares}}",
       "reclaim": "Reclaim",
       "reclaimAll": "Reclaim all",
       "reclaimableAmount": "Available:"
@@ -58,7 +58,7 @@
     },
     "transaction": {
       "addEscrow": {
-        "received": "Received <Amount> delegation in escrow",
+        "received": "Received <Amount/> delegation in escrow",
         "sent": "Delegated <Amount/> to validator"
       },
       "consensusDeposit": {
@@ -123,6 +123,7 @@
     "delegator": "Delegator",
     "from": "From",
     "hash": "Tx Hash",
+    "postfixAmountInBillions": "B",
     "round": "Round",
     "time": "Time",
     "to": "To",
@@ -171,7 +172,7 @@
     "unknownLedgerError": "Unknown ledger error: {{message}}",
     "unknownParaTimeError": "Unknown ParaTime error: {{message}}",
     "usbTransportError": "USB Transport error: {{message}}.",
-    "usbTransportNotSupported": "Current platform does not support WebUSB capability. Try on different platform or browser(preferably Chrome)."
+    "usbTransportNotSupported": "Current platform does not support WebUSB capability. Try on different platform or browser (preferably Chrome)."
   },
   "fatalError": {
     "checkStatus": "Check network status",
@@ -545,7 +546,7 @@
       "from": "From",
       "gas": "Gas",
       "genesisHash": "Genesis hash",
-      "shares": "Gigashares",
+      "shares": "Shares",
       "to": "To",
       "type": "Type",
       "validator": "Validator",