Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow new version of psr/log #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kilatib
Copy link

@kilatib kilatib commented Feb 12, 2025

update Symfony TR-6487

Description

Allow other Symfony versions

@kilatib kilatib requested review from wazelin and poyuki February 18, 2025 16:37
composer.json Outdated
@@ -7,8 +7,8 @@
"require": {
"php": ">=7.2.0",
"ext-json": "*",
"oat-sa/lib-health-check": "^1.1",
"psr/log": "^1.1",
"oat-sa/lib-health-check": "^1.0 || ^2.0",
Copy link
Member

@wazelin wazelin Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"oat-sa/lib-health-check": "^1.0 || ^2.0",
"oat-sa/lib-health-check": "^1.1",

@kilatib kilatib force-pushed the feat/TR-6487/symfony-upgrade branch from 7161b8f to 48f1e9c Compare February 25, 2025 13:22
@kilatib kilatib closed this Feb 25, 2025
@kilatib kilatib reopened this Feb 25, 2025
@kilatib kilatib force-pushed the feat/TR-6487/symfony-upgrade branch from 0421456 to 6c23fe2 Compare February 25, 2025 13:27
@kilatib kilatib force-pushed the feat/TR-6487/symfony-upgrade branch from d6445ff to 2112054 Compare February 25, 2025 13:40
@kilatib kilatib requested a review from wazelin February 25, 2025 13:41
@kilatib kilatib force-pushed the feat/TR-6487/symfony-upgrade branch from bdc0ef9 to eceaeef Compare February 25, 2025 17:54
Copy link
Member

@wazelin wazelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing CI by adding missing composer.json properties.

@kilatib kilatib requested a review from wazelin February 25, 2025 19:32
Copy link

codecov bot commented Feb 25, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants