Fix/AUT-470/FooBar-Extension #192
Conversation
focaloid-dev
requested review from
mike-ionut-mihai-sandu-tao,
bziondik and
AnastasiaArcadia
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
controller/TaoFooBar.php
Outdated
| @@ -0,0 +1,52 @@ | |||
|
|
|||
There was a problem hiding this comment.
empty line,
controller/TaoFooBar.php
Outdated
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| * | ||
| * Copyright (c) 2014-2020 (original work) Open Assessment Technologies SA; |
There was a problem hiding this comment.
bad year
controller/TaoFooBar.php
Outdated
| $this->setData('author', 'Open Assessment Technologies SA'); | ||
| $this->setView('templates/foobar.tpl'); | ||
| } | ||
| } |
There was a problem hiding this comment.
missing \n
controller/structures.xml
Outdated
| <section id="taoFooBar_other" name="Template" url="/taoFooBar/templates/foobar" /> | ||
| </sections> | ||
| </structure> | ||
| </structures> |
There was a problem hiding this comment.
missing \n also we need to allays format our code according to OAT
for PHP --> psr12
for Js we have a specific tool
views/templates/foobar.tpl
Outdated
| @@ -0,0 +1,3 @@ | |||
| <div class="main-container tao-scope"> | |||
| <h1>Hello <?=(get_data('author'))?></h1> | |||
| </div> | |||
There was a problem hiding this comment.
missing \n
views/js/controller/Foo/barex.js
Outdated
| @@ -0,0 +1,26 @@ | |||
|
|
|||
|
|
|||
| define([], function(){ | |||
There was a problem hiding this comment.
format check please,
also the second commit looks good but the initial one is not as you have not used the conventional commits
|
the PR is a start , i did not check any of the item on the list because :
also please take a look at this : overall this is a exercise so this is how you learn , |
Related issue:
https://oat-sa.atlassian.net/browse/AUT-470
Description
This is a foo-bar extension for Onboard Process, No testing environment has been configured in the kitchen Environment.
Current Issue Extension is installed but not showing up in Application Header.
Steps to reproduce:
How to test: Clone the branch and install it in the application .