feat(item.tpl): rendering 'dir' if set as attribute#2367
Open
albertosgz wants to merge 1 commit intodevelopfrom
Open
feat(item.tpl): rendering 'dir' if set as attribute#2367albertosgz wants to merge 1 commit intodevelopfrom
albertosgz wants to merge 1 commit intodevelopfrom
Conversation
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2367 +/- ##
==========================================
Coverage 16.37% 16.37%
Complexity 4207 4207
==========================================
Files 389 389
Lines 12838 12838
==========================================
Hits 2102 2102
Misses 10736 10736 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Karol-Stelmaczonek
approved these changes
May 26, 2023
pnal
approved these changes
May 31, 2023
Contributor
pnal
left a comment
pnal
left a comment
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
|
@mike-ionut-mihai-sandu-tao just to remind you, that you still didn't pay my invoice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AUT-2939
What's changed
Item template renders dir when is setup properly.
Needed for oat-sa/extension-tao-mediamanager#470