fix: Disallow deleting assets that are used in items #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
a team,
tikhanovichA,
KirylHatalski,
pnal,
Karol-Stelmaczonek and
viktar-dzmitryieu-tao
and removed request for
a team
KirylHatalski
approved these changes
Jan 20, 2025
Front-end summary Node 18
|
model/relation/event/processor/ItemDuplicationEventProcessor.php
Outdated
Show resolved
Hide resolved
bartlomiejmarszal
changed the title
Karol-Stelmaczonek
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
…it amount of items when deleting assets
Karol-Stelmaczonek
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
| }); | ||
| foreach ($nestedResources as $nestedResource) { | ||
| $resource = $this->getOntology()->getResource($nestedResource['id']); | ||
| $property = $this->getOntology()->getProperty('http://www.tao.lu/Ontologies/TAOMedia.rdf#RelatedItem'); |
There was a problem hiding this comment.
Cant we use this const ? \oat\taoMediaManager\model\relation\repository\rdf\RdfMediaRelationRepository::ITEM_RELATION_PROPERTY ? Just make it public?
| } else { | ||
| let itemList = haveItemReferences; | ||
| if (itemList.length > overloadLimit) { | ||
| itemList = haveItemReferences.slice(0, overloadLimit); |
There was a problem hiding this comment.
I don't see message saying that there's more items than 15 on this list (and how much), could be handy to make decision what to do next.
Version
There are 0 BREAKING CHANGE, 10 features, 15 fixes |
bartlomiejmarszal
deleted the
fix/ADF-1857/removing-assets-used-in-items-not-possible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing features
Disallow user from removing assets used in items.
How to test:
Add item relation to media on duplicate item, copy item and delete item
Screen.sharing.-.2025-01-22.3_20_18.PM.mp4
Dependencies
oat-sa/generis#1148
https://github.com/oat-sa/tao-core/pull/4180/files