Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check only files when build list of content #528

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

tikhanovichA
Copy link
Contributor

@tikhanovichA tikhanovichA commented Feb 19, 2025

In scope of using GCP file system the listContents method return also directories with files

How to test:

  1. Configure TAO with GcsFileSystemService
  2. import XML asset
  3. Attach CSS to asset
  4. copy the asset

Expected result: Asset is copied without any error message, attached CSS copied without errors
Actual result: Asset is copied with error message, empty read-only CSS file attached to asset together with original

Can be tested on https://construct1-oat-unit07.dev.gcp-eu.taocloud.org/

Copy link

github-actions bot commented Feb 19, 2025

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
16 16 0 0

Copy link

Version

Target Version 12.43.2
Last version 12.43.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@tikhanovichA tikhanovichA requested review from a team, bartlomiejmarszal, KirylHatalski, pnal, Karol-Stelmaczonek and viktar-dzmitryieu-tao and removed request for a team February 20, 2025 11:01
@tikhanovichA tikhanovichA merged commit 5a57580 into develop Feb 24, 2025
5 checks passed
@tikhanovichA tikhanovichA deleted the fix/AUT-4037/copy-assets-with-css branch February 24, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants