move item timer start. #977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the pain, additional samples have been introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of impact could have this change?
This is really important, because if we find there is no impact, we can significantly improve the performances (CPU consumption) of TAO at delivery time (current gain ratio is currently +- 1.7).
Would you like to help by testing this in timing scenarios, especially with our beloved secret blue customer? Is this "start" GET request parameter really in use? Could you help to crawl the frontend source code to see it is really triggered somewhere?
Thanks so much!
PS: we can discuss the "why" internally.
PS2: As soon as we had an exhaustive tour of this, we might envision to enlarge the people assigned as reviewers.
PS3: Please find great QTI Test Samples to test this in this PR!