Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set leeway value to 1s for token validation #196

Merged

Conversation

yaraslau-kavaliou
Copy link
Contributor

@yaraslau-kavaliou yaraslau-kavaliou commented Dec 30, 2024

Ticket - https://oat-sa.atlassian.net/browse/AUT-4031

For portal to authoring redirection a new token is created every time. During a token's issue date validation it sometimes can occur that iat token's timestamp is 1s later than the current time, which fails the token has not to be issued in the future validation.
The proposed solution is to add a leeway period to make such validation less strict.

Copy link

@olegkhuss olegkhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yaraslau-kavaliou yaraslau-kavaliou merged commit 9858265 into master Jan 3, 2025
5 checks passed
@yaraslau-kavaliou yaraslau-kavaliou deleted the fix/AUT-4031/leeway-set-for-token-validation branch January 3, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants