Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #160 redirect to the actual redirect_uri after verifying that it matches the registered tool host #199

Merged

Conversation

wazelin
Copy link
Member

@wazelin wazelin commented Jan 27, 2025

TR-6465 / #160

This resolves #160.

@wazelin wazelin requested review from pedromarceOAT, a team, kilatib and poyuki January 27, 2025 17:27
@wazelin wazelin force-pushed the fix/TR-6465/redirect-from-pltform-launch-authentication branch 2 times, most recently from 6e7d9b0 to b113434 Compare January 27, 2025 20:25
@wazelin wazelin force-pushed the fix/TR-6465/redirect-from-pltform-launch-authentication branch from b113434 to 32f6f40 Compare January 27, 2025 20:39
Copy link

@kilatib kilatib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@wazelin wazelin merged commit 8d8d215 into master Jan 28, 2025
5 checks passed
@wazelin wazelin deleted the fix/TR-6465/redirect-from-pltform-launch-authentication branch January 28, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OidcAuthenticator response is send to target_link_uri instead of redirect_uri
2 participants