Fix/TR-6195/remove tao-core-libs dependency #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatymart
commented
Jul 15, 2024
There was a problem hiding this comment.
Libs file: https://github.com/oat-sa/tao-core-libs-fe/blob/master/src/pathdefinition.js
This is only loaded for unit tests.
oatymart
commented
Jul 15, 2024
Comment on lines
-27
to
-28
| import 'webcrypto-shim'; | ||
| import { TextEncoder } from 'fastestsmallesttextencoderdecoder'; |
There was a problem hiding this comment.
These are out because
- window.crypto.subtle became supported in all browsers and Node
- TextEncoder the same
oatymart
commented
Jul 15, 2024
src/core/uuid.js
Outdated
There was a problem hiding this comment.
This file is a copy of https://github.com/oat-sa/tao-core-libs-fe/blob/master/src/uuid.js
Coverage Report
|
oatymart
requested review from
olga-kulish,
taopkorczak,
Nicholass,
yairkukielka and
jsconan
olga-kulish
reviewed
Aug 2, 2024
olga-kulish
reviewed
Aug 2, 2024
Version
There are 0 BREAKING CHANGE, 1 feature, 1 fix |
olga-kulish
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Very nice improvement
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
jsconan
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Review Checklist
-
New code is covered by tests (if applicable) - Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
-
New code is not subject to concurrency issues (if applicable) - Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/TR-6195
The link between
tao-core-sdkandtao-core-libshas a small surface area: only 2 libs files are really used in sdk.This PR aims to break that link, meaning that
tao-core-sdkcan then be installed in projects (e.g. Nextgen) without installingtao-core-libsand all the old CurrentGen dependencies it brings in.Dependencies removed because no usage found in
tao-core-sdk:dompurifygampinteractjsmimemoment-timezonepopper.jspromise-limitraphaelselect2tooltip.jsDependencies removed due to better browser support:
fastestsmallesttextencoderdecoderwebcrypto-shimHow to test
In CurrentGen TAO
Deployed to: https://test-tr-6195-authoring.v3.playground.taocloud.org/
uuidis quite commonly called, in case you want to check it.DEBUG_MODEtrue and false inconfig/generis.config.phpIn LDS
In a NextGen project (e.g. tao-deliver-fe)