[Fix] Keep translation QTI ID the same #4206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
2 tasks
gabrielfs7
reviewed
Feb 14, 2025
| $this->getQtiIdentifierSetter($resource)->set([ | ||
| AbstractQtiIdentifierSetter::OPTION_RESOURCE => $resource, | ||
| AbstractQtiIdentifierSetter::OPTION_IDENTIFIER => $uniqueIdentifier, | ||
| ]); | ||
|
|
||
| if ($this->featureFlagChecker->isEnabled('FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIER')) { |
There was a problem hiding this comment.
@shpran I wonder if we really need this if here now? If we are creating a translation, it may be useful to for them to have always the same TaoOntology::PROPERTY_UNIQUE_IDENTIFIER?
I know this is only needed for HKDir for the moment, but I do not see why restrict is as default behavior.
- I know it was previous rule in place, but better thinking about it, we may remove this condition.
There was a problem hiding this comment.
If for us it's not a problem if we are going to set this property every time - I will remove this condition 🙂
There was a problem hiding this comment.
Done: 7f03156
Also did for:
gabrielfs7
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Awesome!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
1 task
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUT-3772
Changes
How to test
FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIERfeature flagFEATURE_FLAG_TRANSLATION_ENABLEDfeature flagReady for translationCompanion PRs