fix: correct distance-to-score conversion for l2 and inner_product metrics in SeekDBStore#8
Open
knqiufan wants to merge 1 commit intoob-labs:mainfrom
Open
fix: correct distance-to-score conversion for l2 and inner_product metrics in SeekDBStore#8knqiufan wants to merge 1 commit intoob-labs:mainfrom
knqiufan wants to merge 1 commit intoob-labs:mainfrom
Conversation
…trics in SeekDBStore The search score calculation previously assumed cosine distance (`Math.max(0, 1 - distance)`), producing incorrect similarity scores when SeekDB is configured with l2 or inner_product distance metrics. Add metric-aware `distanceToScore()` that matches the Python OceanBase implementation: - cosine: max(0, 1 - d/2) - l2: 1 / (1 + d) - inner_product: clamp((-d + 1) / 2, 0, 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SeekDBStore.search()hardcodedMath.max(0, 1 - distance)for score conversion, which only works for cosine distance. When configured withl2orinner_product, similarity scores are incorrect, causing unreliable search ranking and threshold filtering.distanceToScore()method with metric-specific formulas, matching the Python OceanBase implementation:cosine:max(0, 1 - d/2)— distance range [0, 2]l2:1 / (1 + d)— distance range [0, +∞)inner_product:clamp((-d + 1) / 2, 0, 1)— negative distance conventionChanged files
src/storage/seekdb/seekdb.tsdistanceMetricfield,distanceToScore()method, updatesearch()tests/unit/storage/seekdb.test.tsdistanceToScore conversiontest suite (5 cases)Test plan
distanceToScoretests cover cosine, l2, inner_product, and null input